fix: resolve all failing tests across api and shared packages#10
Open
stooit wants to merge 1 commit into
Open
Conversation
- Fix auth middleware case-sensitivity: match HTTP methods in uppercase (POST not post) - Add missing badRequest import in users route handler - Rename User type field from userName to username for consistency with tests - Implement paginate() utility function in shared package - Add process type declaration in auth.ts to fix TypeScript error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publicMethodsarray used lowercase"post"but HTTP methods from Hono arrive as uppercase"POST". Fixed to match correctly.badRequestwas used but not imported from../lib/errors. Added the import.Usertype inpackages/shared/src/types.tsuseduserNamebut all tests and route handlers expectusername. Renamed the field.paginate()inpackages/shared/src/utils/pagination.tswas throwing "not implemented". Implemented it to return{ data, page, pageSize, total, totalPages }.declare var processtype declaration inauth.tsto resolve the TS2580 error without adding@types/node.Verification
bun test)npx tsc --noEmit— remaining errors are only in test files due to missingbun:testtype declarations)Assumptions
processdeclaration is minimal and scoped to the single file that uses it